-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vaadin 10 and SpringBoot 2 #317
Comments
|
I'm using Security extension and EventBus, SideBar and MVP addons. It would be great to have it compatible with Vaadin 10 (MVP and SideBar) and SpringBoot 2 (Security) |
I think @peholmst is bit busy ATM, so help would be appreciated on this. I think the basics shouldn't be too hard to migrate as the fundamental architecture is not that much different. I can certainly help, do code reviews and ask the core team for help when needed (e.g. opening some APIs), but I wouldn't like to take the lead on this. |
Can EventBus be used with Vaadin 10 without modifications? |
No, it will not work. The scopes are different in Vaadin 10. |
I made a PR for updating the event bus here Although the project with that PR is in a state where it uses different versions than all other add-ons, so either they should be migrated, or maybe the event bus split out. |
Awesome! I think we should we create a separate flow branch and consider releasing the first version with only the event bus. What do you think @peholmst? |
That branch should probably remove all but platform compatible stuff and we can then later add features back when somebody finds time to work on the features. |
@mstahv Go for it! |
Landed the patch to flow branch. Let's use that to develop the first Flow version |
What is left to do for a first release with only the event bus? |
What is the future with event bus with Flow ? |
I think we should definitely look to cut a first build. @eriklumme Do you think you could find out time for some short smoke test session? |
I made some proposal of updates for eventbus addon in #322 to be able to compile and run tests with flow version. |
I'll try to find time this week |
Vaadin 14 is just a few days away from being released so I understand if everyone is busy. The support for eventbus would be the last piece for me to be able to migrate an application from Vaadin 8. Any update? |
Vaadin 14 released, any update on this? @eriklumme |
Hi @andersforsell , I've been very busy lately so haven't had time to look at this, but it's high on my priority list. It would also require some action from @peholmst in terms of checking out the already open PRs. |
@andersforsell Discussing with @peholmst, we decided that the event bus should probably be remade from scratch, due to the security issue explained here https://github.com/peholmst/vaadin4spring/blob/master/eventbus/README.md In short, listeners in the application scope are notified within the security context of the sender, rather than that of the receiver. This is not an issue in the UI or session scopes. Until the new version is completed, Petter released just the ported version of the old event bus. It can now be found on Maven central as version 14.0.0 |
Are you going to add support of Vaadin 10 and SpringBoot 2?
The text was updated successfully, but these errors were encountered: