Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 10 and SpringBoot 2 #317

Open
ekomrak opened this issue May 29, 2018 · 19 comments
Open

Vaadin 10 and SpringBoot 2 #317

ekomrak opened this issue May 29, 2018 · 19 comments

Comments

@ekomrak
Copy link

ekomrak commented May 29, 2018

Are you going to add support of Vaadin 10 and SpringBoot 2?

@christoph-frick
Copy link
Contributor

christoph-frick commented May 29, 2018

Have you seen https://github.com/devsoap/gradle-vaadin-flow ? Wrong project, not relevant. Please ignore.

@ekomrak
Copy link
Author

ekomrak commented May 29, 2018

I'm using Security extension and EventBus, SideBar and MVP addons. It would be great to have it compatible with Vaadin 10 (MVP and SideBar) and SpringBoot 2 (Security)

@mstahv
Copy link
Collaborator

mstahv commented Jul 6, 2018

I think @peholmst is bit busy ATM, so help would be appreciated on this. I think the basics shouldn't be too hard to migrate as the fundamental architecture is not that much different.

I can certainly help, do code reviews and ask the core team for help when needed (e.g. opening some APIs), but I wouldn't like to take the lead on this.

@andersforsell
Copy link

Can EventBus be used with Vaadin 10 without modifications?

@peholmst
Copy link
Owner

peholmst commented Feb 8, 2019

No, it will not work. The scopes are different in Vaadin 10.

@eriklumme
Copy link
Collaborator

I made a PR for updating the event bus here

#320

Although the project with that PR is in a state where it uses different versions than all other add-ons, so either they should be migrated, or maybe the event bus split out.

@mstahv
Copy link
Collaborator

mstahv commented Feb 15, 2019

Awesome! I think we should we create a separate flow branch and consider releasing the first version with only the event bus. What do you think @peholmst?

@mstahv
Copy link
Collaborator

mstahv commented Feb 15, 2019

That branch should probably remove all but platform compatible stuff and we can then later add features back when somebody finds time to work on the features.

@peholmst
Copy link
Owner

@mstahv Go for it!

@mstahv
Copy link
Collaborator

mstahv commented Feb 15, 2019

Landed the patch to flow branch. Let's use that to develop the first Flow version

@andersforsell
Copy link

What is left to do for a first release with only the event bus?
I am about to migrate a Vaadin 8 application to Vaadin 12 but would like to keep using the event bus.

@simpletasks
Copy link
Contributor

What is the future with event bus with Flow ?
When we can expect release of event bus addon for Flow ?
Event bus addon is important part of ours Vaadin 8 applications. We now need to migrate to Vaadin 13 preparing for Vaadin 14 development.

@mstahv
Copy link
Collaborator

mstahv commented Apr 28, 2019

I think we should definitely look to cut a first build. @eriklumme Do you think you could find out time for some short smoke test session?

@simpletasks
Copy link
Contributor

I made some proposal of updates for eventbus addon in #322 to be able to compile and run tests with flow version.

@eriklumme
Copy link
Collaborator

I'll try to find time this week

@andersforsell
Copy link

andersforsell commented Jun 30, 2019

Vaadin 14 is just a few days away from being released so I understand if everyone is busy. The support for eventbus would be the last piece for me to be able to migrate an application from Vaadin 8. Any update?

@andersforsell
Copy link

Vaadin 14 released, any update on this? @eriklumme

@eriklumme
Copy link
Collaborator

Hi @andersforsell , I've been very busy lately so haven't had time to look at this, but it's high on my priority list.

It would also require some action from @peholmst in terms of checking out the already open PRs.

@eriklumme
Copy link
Collaborator

eriklumme commented Aug 26, 2019

@andersforsell Discussing with @peholmst, we decided that the event bus should probably be remade from scratch, due to the security issue explained here https://github.com/peholmst/vaadin4spring/blob/master/eventbus/README.md

In short, listeners in the application scope are notified within the security context of the sender, rather than that of the receiver. This is not an issue in the UI or session scopes.

Until the new version is completed, Petter released just the ported version of the old event bus. It can now be found on Maven central as version 14.0.0
https://mvnrepository.com/artifact/org.vaadin.spring.addons/vaadin-spring-addon-eventbus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants