Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'hotfix' for parser performance issue #1531

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Commits on Jun 2, 2021

  1. fix(parser): Use 'hotfix' for parser performance issue

    A performance issue in the Pelias Parser where certain inputs can cause
    long parse times and out of memory errors was [recently reported](#1530).
    
    This change implements a short term fix by disabling some functionality
    around unit number parsing that was contributing to the issue. From our
    analysis it's not so much that the unit number parsing _caused_ the
    issue, but it was the most recently added functionality that contributed
    to it.
    
    While we develop a longer term fix, which should allow us to keep unit
    number parsing around, this "hotfix" will keep everything running
    smoothly. Unit numbers are not yet fully supported by Pelias so there
    _shouldn't_ be any major loss in functionality.
    
    Fixes #1530
    orangejulius committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4061a2f View commit details
    Browse the repository at this point in the history