Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognise 6-position postcodes in addresses in the Netherlands (without spaces) #127

Closed
emacgillavry opened this issue Jan 28, 2021 · 1 comment · Fixed by #126
Closed

Recognise 6-position postcodes in addresses in the Netherlands (without spaces) #127

emacgillavry opened this issue Jan 28, 2021 · 1 comment · Fixed by #126
Labels
bug Something isn't working

Comments

@emacgillavry
Copy link
Contributor

emacgillavry commented Jan 28, 2021 •
edited
Loading

Typically, addresses in the Netherlands have 4 digits, followed by 0 or 1 space, followed by 2 alphanumeric characters, e.g. "7512EC" or "7512 EC". The alphanumeric characters should not be "SA", "SD" or "SS":

/^[1-9][0-9]{3} ?(?!sa|sd|ss)[a-z]{2}$/i;

This bug is to track the first case, i.e. "7512EC", as part of PR #126 .
@emacgillavry emacgillavry added the bug Something isn't working label Jan 28, 2021
emacgillavry added a commit to webmapper/parser that referenced this issue Jan 28, 2021
@emacgillavry
Recognise 6 position postcodes in NL, addressing pelias#127.
4fc715c
@missinglink
Copy link
Member

The original pattern was sourced from the libaddressinput project, but yours looks better!
https://www.gstatic.com/chrome/autofill/libaddressinput/chromium-i18n/ssl-address/data/NL

emacgillavry added a commit to webmapper/parser that referenced this issue Jan 30, 2021
@emacgillavry
First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing pelia…
a2f4dc5 
…s#127.
@emacgillavry emacgillavry mentioned this issue Jan 30, 2021
Merged
9 tasks
emacgillavry added a commit to webmapper/parser that referenced this issue Sep 7, 2021
@emacgillavry
Recognise 6 position postcodes in NL, addressing pelias#127.
5825840
emacgillavry added a commit to webmapper/parser that referenced this issue Sep 7, 2021
@emacgillavry
First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing pelia…
14f59ca 
…s#127.
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry @Joxit
Recognise 6 position postcodes in NL, addressing #127.
57f5e34
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry @Joxit
First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing #127.
a474a3d
@Joxit Joxit closed this as completed in #126 Sep 7, 2021
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry
feat(nl): improve support of NL addresses (#126)
a1af69b 
* Examples of correct addresses in NL.
* Recognise 6 position postcodes in NL, addressing #127.
* Check for -plein as street type.
* Adjustments for typo 'plain' instead of 'plein' in libpostal resources. Addressing #128.
* Put 'test' back in as per #126 (comment).
* Prevent 'St' as a suffix in NL streetnames. Add Jr and Sr. Addressing #126.
* First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing #127.
* Adjective 'korte' no longer a personal title. Addressing #129.
* Tests and fix for typo 'BurgeRmeester'. Addressing #130.
* Tests, code, and configs for '-daal', '-burg', '-baan'. Addressing #131 and #133.
* Config for '-burg' not separable. Addressing #131.
* Remove test for NL postal codes WITH spaces. Regex ok. #134
* Fix formatting spaces at the end of the line.
* Also use directionals to parse Dutch street addresses. #137
* Add Dutch titulature for street name recognition. (#130)
* Add 'plantsoen' as a street type. (#128).
* Remove test for NL locality with stopword.
@emacgillavry emacgillavry mentioned this issue Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Examples of correct addresses in NL webmapper/parser
2 participants
@missinglink @emacgillavry