Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Street type '-plein' not recognised in Netherlands addresses #128

Closed
emacgillavry opened this issue Jan 28, 2021 · 1 comment · Fixed by #126
Closed

Street type '-plein' not recognised in Netherlands addresses #128

emacgillavry opened this issue Jan 28, 2021 · 1 comment · Fixed by #126
Labels
bug Something isn't working

Comments

@emacgillavry
Copy link
Contributor

emacgillavry commented Jan 28, 2021 •
edited
Loading

Passing in "Rembrandtplein, Amsterdam", only Amsterdam is handled as a locality, but Rembrandtplein is not recognised as a street.

This bug is to track "Rembrandtplein", as part of PR #126 .
@emacgillavry emacgillavry added the bug Something isn't working label Jan 28, 2021
emacgillavry added a commit to webmapper/parser that referenced this issue Jan 28, 2021
@emacgillavry
Adjustments for typo 'plain' instead of 'plein' in libpostal resource…
91226bc 
…s. Addressing pelias#128.
@missinglink
Copy link
Member

Is this suffix 'separable', ie. do you ever see street names in the form "Rembrandt Plein" (two words)?

If so then we have some code to handle generating alternative forms, as it's also common in DE/CH where people may interchangeably use "Hauptstrasse" or "Haupt Strasse" or "Haupt-strasse" if they're unsure which form it should be written in.

https://github.com/openvenues/libpostal/blob/master/resources/dictionaries/nl/concatenated_suffixes_separable.txt

@emacgillavry emacgillavry mentioned this issue Jan 30, 2021
Merged
9 tasks
emacgillavry added a commit to webmapper/parser that referenced this issue May 10, 2021
@emacgillavry
Add 'plantsoen' as a street type. (pelias#128).
9764fc8
emacgillavry added a commit to webmapper/parser that referenced this issue Sep 7, 2021
@emacgillavry
Adjustments for typo 'plain' instead of 'plein' in libpostal resource…
5f00b01 
…s. Addressing pelias#128.
emacgillavry added a commit to webmapper/parser that referenced this issue Sep 7, 2021
@emacgillavry
Add 'plantsoen' as a street type. (pelias#128).
ae854ac
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry @Joxit
Adjustments for typo 'plain' instead of 'plein' in libpostal resource…
8333a4d 
…s. Addressing #128.
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry @Joxit
Add 'plantsoen' as a street type. (#128).
c3cb557
@Joxit Joxit closed this as completed in #126 Sep 7, 2021
Joxit pushed a commit that referenced this issue Sep 7, 2021
@emacgillavry
feat(nl): improve support of NL addresses (#126)
a1af69b 
* Examples of correct addresses in NL.
* Recognise 6 position postcodes in NL, addressing #127.
* Check for -plein as street type.
* Adjustments for typo 'plain' instead of 'plein' in libpostal resources. Addressing #128.
* Put 'test' back in as per #126 (comment).
* Prevent 'St' as a suffix in NL streetnames. Add Jr and Sr. Addressing #126.
* First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing #127.
* Adjective 'korte' no longer a personal title. Addressing #129.
* Tests and fix for typo 'BurgeRmeester'. Addressing #130.
* Tests, code, and configs for '-daal', '-burg', '-baan'. Addressing #131 and #133.
* Config for '-burg' not separable. Addressing #131.
* Remove test for NL postal codes WITH spaces. Regex ok. #134
* Fix formatting spaces at the end of the line.
* Also use directionals to parse Dutch street addresses. #137
* Add Dutch titulature for street name recognition. (#130)
* Add 'plantsoen' as a street type. (#128).
* Remove test for NL locality with stopword.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Examples of correct addresses in NL webmapper/parser
2 participants
@missinglink @emacgillavry