Update plugin code for use with Mau v3 #28
Conversation
|
@justinmayer when you have 5 minutes this is ready. I had some issues with tests, but I fixed them now. Thanks! |
|
@justinmayer pretty please? 😹 🙏 |
justinmayer
changed the title
There was a problem hiding this comment.
Hey Leonardo. It has been a busier-than-expected summer, so I apologize for the delay in taking a look at this PR.
In addition to the comment I made about not manually fiddling with the version number, there are a number of updated plugin-related "best practices" that I would like to make before the next release of this plugin, assuming that is okay with you. You can see what some of those changes are by looking at the changes I've made to the Cookiecutter Pelican plugin template.
I will make those proposed changes in a separate branch and PR so that you can have a look and tell me what you think.
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "pelican-mau-reader" | |||
| version = "2.0.0" | |||
| version = "3.0.0" | |||
There was a problem hiding this comment.
When using AutoPub to manage publishing releases, it is important not to manually touch the version number. Otherwise, what will happen is that AutoPub will increment it automatically to version 4.0.0, which is presumably not what you want to do for the imminent upcoming release of this plugin. 😊
There was a problem hiding this comment.
@justinmayer thanks. Honestly, I completely forgot I changed that. I will revert the change. I'll wait for your other PR with the proposed changes, then when that is merged I will rebase this one. Thanks!
There was a problem hiding this comment.
I submitted #29, which I fear brings changes that will require a non-trivial rebase for you. If that is the case, I'm so sorry! 😅
|
The aforementioned PR has been merged, so this PR is ready to be rebased onto current |
lgiordani
force-pushed
the
support-mau3
branch
from
0740fce to
79a1a22
Compare
|
@justinmayer I preferred not to rebase, I manually moved my changes to a new branch and force pushed. The amount of changes was limited and I felt it was faster this way. Ready to be reviewed! |
|
@justinmayer I can't remember the process here. Shall I add here the file to release a major version or shall I first merge and then send a PR with that file? |
|
While either technique will work equally well, if it were me, I would probably add the |
This creates a new version of the package that uses Mau v3.