Add Upper index for email in EmailAddress model #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #3129 |
pennersr
reviewed
Aug 25, 2023
allauth/account/models.py
Outdated
| @@ -41,6 +43,7 @@ class Meta: | |||
| condition=Q(verified=True), | |||
| ) | |||
| ] | |||
| indexes = [Index(Upper("email"), name="idx_upper_email")] | |||
There was a problem hiding this comment.
The other indexes are named like this:
Indexes:
"account_emailaddress_pkey" PRIMARY KEY, btree (id)
Could you rename this one to account_emailaddress_upper_email ?
There was a problem hiding this comment.
I have renamed the index and manually renamed in migration file, i hope that's the correct way instead of deleting and regenerating the migration file.
|
One final thing, can you make sure the code is black formatted? The build is failing on that now. Thanks. |
varunsaral
force-pushed
the
create_email_upper_index
branch
from
98951b4
to
0b8556d
Compare
|
I did the black formatting, sorry for the inconvenience. |
|
applied isort as suggested by tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add index for email field in EmailAddress Model, this is to improve email__iexact filter in function filter_users_by_email