Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test vector utility for R1CS circuits #110

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Nov 19, 2024

This was created for debugging why tests are failing against mainnet proving and verification keys in penumbra-zone/penumbra#4927

This PR:

  1. Adds a small utility for generating proving and verification keys, which then get committed (similar to the parameter-setup tool in the penumbra monorepo)
  2. Loads those keys in the R1CS tests in this repo

The benefit of this is that if a dependency is updated that changes the circuits, we'll detect it with these tests. We have similar tests in the penumbra monorepo but it would be nice to have them in all the crypto dependencies with R1CS gadgets so we can more easily identify which changes are causing the breakage.

@redshiftzero redshiftzero changed the title add wip: add test vector utility for R1CS circuits Nov 19, 2024
@redshiftzero redshiftzero changed the title wip: add test vector utility for R1CS circuits add test vector utility for R1CS circuits Nov 19, 2024
@redshiftzero redshiftzero merged commit b75c815 into main Nov 19, 2024
6 checks passed
@redshiftzero redshiftzero deleted the test-circuit-guard branch November 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant