Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SwapExecutions from consensus state #4084

Closed
Tracked by #1724
hdevalence opened this issue Mar 22, 2024 · 0 comments · Fixed by #4107
Closed
Tracked by #1724

Remove SwapExecutions from consensus state #4084

hdevalence opened this issue Mar 22, 2024 · 0 comments · Fixed by #4107
Assignees
@erwanor
Labels
consensus-breaking breaking change to execution of on-chain data _P-V1 Priority: slated for V1 release state-breaking breaking change to on-chain data

Comments

@hdevalence
Copy link
Member

Is your feature request related to a problem? Please describe.

We store all of the execution traces in the SwapExecution in consensus-verifiable storage. This data is never used by the application and the only reason we put it there was that at the time we developed the feature we didn't have an indexer.

Describe the solution you'd like

Move it out to nonverifiable storage, so that we could remove it later if desired without breaking the app hash.

Additional context
See state_key::swap_execution
@hdevalence hdevalence added _P-V1 Priority: slated for V1 release consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data labels Mar 22, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Mar 22, 2024
@erwanor erwanor mentioned this issue Mar 22, 2024
Open
65 tasks
@conorsch conorsch modified the milestone: v1 Mar 25, 2024
@erwanor erwanor mentioned this issue Mar 26, 2024
Merged
erwanor added a commit that referenced this issue Mar 26, 2024
@erwanor
upgrades: write a migration script for #4084
cfb4be1
This was referenced Mar 26, 2024
Merged
Closed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Mar 28, 2024
conorsch pushed a commit that referenced this issue Mar 28, 2024
@erwanor @conorsch
upgrades: write a migration script for #4084
aa3faf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
consensus-breaking breaking change to execution of on-chain data _P-V1 Priority: slated for V1 release state-breaking breaking change to on-chain data
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dex: move SwapExecutions to NV storage penumbra-zone/penumbra
3 participants
@hdevalence @conorsch @erwanor