-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: rework action-level EffectingData
implementations
#2931
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ca2d021 - Browse repository at this point
Copy the full SHA ca2d021View commit details -
crypto: use proto encoding of
SpendBody
forEffectingData
For spends, only the body is considered effecting data, so we just hash the proto-encoded body.
Configuration menu - View commit details
-
Copy full SHA for 4d6cb25 - Browse repository at this point
Copy the full SHA 4d6cb25View commit details -
crypto: use proto-encoding of entire Dao action for
EffectingData
For DAO spends, outputs, and deposits, the entire action is considered effecting data.
Configuration menu - View commit details
-
Copy full SHA for 56fa55a - Browse repository at this point
Copy the full SHA 56fa55aView commit details -
crypto: use proto encoded of swap / swap claim bodies for effect hash
Note that previously the batch swap output data was _not_ included in the effect hash for the swap claim.
Configuration menu - View commit details
-
Copy full SHA for ae1823c - Browse repository at this point
Copy the full SHA ae1823cView commit details
Commits on Aug 15, 2023
-
crypto: rework effect hash for staking-related actions
For delegate and undelegate actions, the effecting data should be the entire action. For undelgate claims however, the effecting data should just be the body, thus excluding the proof which is on the undelegate claim action.
Configuration menu - View commit details
-
Copy full SHA for 79529ee - Browse repository at this point
Copy the full SHA 79529eeView commit details -
crypto: rework effect hash for position management actions
The `PositionClose`, `PositionWithdraw`, and `PositionRewardClaim` actions effect hash still hashes the same data - but now first proto-encoded. The `PositionOpen` effect hash is slightly modified. Previously the `PositionOpen` effect hash consisted of: * The reserves R_1 and R_2 * The ID of the position, which is a hash computed from the nonce, asset IDs of the trading pair, the fee, and p and q Now, by using the proto-encoded position, the effect hash includes the: * State, which is an enum determining if the position is opened, closed, claimed, or withdrawn (new) * Reserves R_1 and R_2 * Phi (trading function), which means the fee, p, and q, as well as the trading pair (two asset IDs) * Nonce * A `close_on_fill` boolean indicating if this position is a limit order (new) The `PositionOpen` effect hash no longer includes the ID.
Configuration menu - View commit details
-
Copy full SHA for fd351f6 - Browse repository at this point
Copy the full SHA fd351f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2532ca2 - Browse repository at this point
Copy the full SHA 2532ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff862d - Browse repository at this point
Copy the full SHA 8ff862dView commit details
Commits on Aug 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7be7f5f - Browse repository at this point
Copy the full SHA 7be7f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f74e896 - Browse repository at this point
Copy the full SHA f74e896View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdbfac7 - Browse repository at this point
Copy the full SHA cdbfac7View commit details