-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ibc)!: handle ibc withdrawals correctly #4787
Merged
Merged
Commits on Aug 2, 2024
-
fix(ibc)!: handle ibc withdrawals correctly
This commit adds a `logic_version` flag to withdrawals, to allow issuing compat address withdrawals. It also implements correct error handling on withdrawal attemtps when counterparty chains return an error.
Configuration menu - View commit details
-
Copy full SHA for 76a21be - Browse repository at this point
Copy the full SHA 76a21beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92fedd8 - Browse repository at this point
Copy the full SHA 92fedd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b518d4 - Browse repository at this point
Copy the full SHA 0b518d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 437e662 - Browse repository at this point
Copy the full SHA 437e662View commit details
Commits on Aug 3, 2024
-
feat(pd)!: migration for ibc noble fixes
This commit adds a pd migration, intended to permit upgrade coordination, so that breaking changes related to ibc withdrawal handling can be made to pd safely. The migration doesn't alter chain state: it simply flips the halt bit off, and permits the chain to resume, after folks have upgraded to a new version of pd. This approach assumes that an upgrade proposal was submitted and passed, in order to halt the chain in a coordinated upgrade. chore: bump crate versions to 0.80.0-alpha.1
Configuration menu - View commit details
-
Copy full SHA for 49626ef - Browse repository at this point
Copy the full SHA 49626efView commit details -
feat(pd)!: stateful migration for IBC noble fixes
This adds a state change to the migration, in order to replace all of the packets which had error acknowledgements, so that, post-migration, the acks can be replayed with the correct logic for error acks, the packets having been replaced in the state. This also changes the IBC component visibility of a trait to reuse the logic for inserting packet commitments.
Configuration menu - View commit details
-
Copy full SHA for da64c5b - Browse repository at this point
Copy the full SHA da64c5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b195d - Browse repository at this point
Copy the full SHA 73b195dView commit details
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e1f68e - Browse repository at this point
Copy the full SHA 0e1f68eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.