🐛 Fix multi-dom capture when using the snapshot command #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
While testing multi-dom support with the snapshot command, I noticed two issues that this PR fixes.
When both
delayUploadsanddeferUploadsaretrue, the snapshot queue acts delayed but not deferred. This is fixed by checking for!deferUploadsbefore automatically flushing the queue.When the first snapshot is taken at the initial width, it is missing it's singular
width. This happened becausewidthwas undefined for the first loop, and fixed by setting it to the first width.One test was updated to test for both of these issues. First
delayUploadswas added to ensure it does not affectdeferUploads. Second, debug logging was added to test for a specific snapshot log to verify each singular width.