🐛 Pass auth headers when requesting assets directly #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
force-pushed
the
rd/pass-auth-to-node-request
branch
from
e0e8eee to
70b2128
Compare
wwilsman
reviewed
Jun 30, 2022
packages/core/test/discovery.test.js
Outdated
Comment on lines
878
to
889
| <html> | ||
| <head> | ||
| <style> | ||
| @font-face { font-family: "test"; src: url("font-auth/font.woff") format("woff"); } | ||
| body { font-family: "test", "sans-serif"; } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <p>Hello Percy!<p> | ||
| ${' '.repeat(1000)} | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Very small nitpick, these all look like they could be indented one more space.
Right now it's indented 7 spaces, when you probably intended it to be an even 8.
Robdel12
force-pushed
the
rd/pass-auth-to-node-request
branch
from
70b2128 to
955be45
Compare
|
@Robdel12 thank you for finding and solving this bug, my project was suffering from this exact problem. Tested @percy/cli 1.6.1 and my woff2 fonts behind basic auth works like a charm again! Great work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
In #921 we realized font responses were being corrupted through the browsers request interception API. To get around that, we now request and save fonts straight from node as a binary (no encoding). In that PR, I forgot to pass the auth config to the request that's being made, which will prevent sites behind auth from capturing fonts properly.
This PR adds the request headers the browser has to the node request we made to capture the fonts directly. Also adds a debug log when we are requesting these fonts directly.
Closes #969