Skip to content

Commit

Permalink
🐛 Fix @percy/sdk-utils amd import (#611)
Browse files Browse the repository at this point in the history
The upstream package now defines its own entry name. It seems that this causes the ember build
system to fall over when it attempts to name the entry using the `as` option. Removing this option
makes the build system happy again.
  • Loading branch information
wwilsman authored Jul 28, 2022
1 parent a2b5b7e commit 858b94b
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 41 deletions.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
included() {
this._super.included.apply(this, arguments);
this.import('node_modules/@percy/sdk-utils/dist/bundle.js', {
using: [{ transformation: 'amd', as: '@percy/sdk-utils' }],
using: [{ transformation: 'amd' }],
type: 'test'
});
},
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"configPath": "tests/dummy/config"
},
"dependencies": {
"@percy/sdk-utils": "^1.1.1",
"@percy/sdk-utils": "^1.6.4",
"ember-cli-babel": "^7.26.11"
},
"devDependencies": {
Expand All @@ -44,7 +44,7 @@
"@ember/test-helpers": "^2.2.5",
"@glimmer/component": "^1.0.4",
"@glimmer/tracking": "^1.0.4",
"@percy/core": "^1.1.1",
"@percy/core": "^1.6.4",
"@types/mocha": "^9.0.0",
"@types/qunit": "^2.11.1",
"babel-eslint": "^10.1.0",
Expand Down
76 changes: 38 additions & 38 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1363,33 +1363,33 @@
"@nodelib/fs.scandir" "2.1.5"
fastq "^1.6.0"

"@percy/client@1.6.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/client/-/client-1.6.1.tgz#6bb136c2fe0ab0490acc898de21f8ab3508420a5"
integrity sha512-e5ToG88O1gDDOuQ+i4989vKCfF+CsPSGG9VA06IKSYNP4QBATe9/RYERZ5jk118uEutjxi8lIjzet0eg8rv7BA==
"@percy/client@1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/client/-/client-1.6.4.tgz#ac7fd6c98144661574dc028587935570c706a7d3"
integrity sha512-LbJg/xhrXavHx4ZiijpAq5fpELKszePF0kGMvBHFeEorVjqTPmkZQg1pQW480ND+F/h6sLk15ucU0Aylp2eooA==
dependencies:
"@percy/env" "1.6.1"
"@percy/logger" "1.6.1"
"@percy/env" "1.6.4"
"@percy/logger" "1.6.4"

"@percy/config@1.6.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/config/-/config-1.6.1.tgz#11fb960dca4ecc0575349382a973b6c5c941363a"
integrity sha512-UiB4gpt01VgPUF4ObZBixR1Wwi/ZUaMXBUxmE3wOa3zZrtZXOzbZwQGcntw5ToEq6OQBP100q1vetnP8xhFQtQ==
"@percy/config@1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/config/-/config-1.6.4.tgz#31812d1f949f22f6589e87027716d29271822e67"
integrity sha512-e9e6CneEs2nmY3kstr5SNaoXT7LRk3Ga/noioSA5HNWPMqKPRwZaMlYLWA0NMSCbVcShMAqbRpa4FEbYTbpGGw==
dependencies:
"@percy/logger" "1.6.1"
"@percy/logger" "1.6.4"
ajv "^8.6.2"
cosmiconfig "^7.0.0"
yaml "^2.0.0"

"@percy/core@^1.1.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/core/-/core-1.6.1.tgz#f18681ba4ba1d8f25cfe2c624424749ae0b2590a"
integrity sha512-a4EeoynE4pU7qExfLr56nmZNu3ozeCNFk6rCBQqoXbSJy6UVG8nj7U8AWEPeBHqtdk2M+30YAVr6mJCQjkZZ7w==
"@percy/core@^1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/core/-/core-1.6.4.tgz#8dc8b78e175b7312ab00ce05043f2b2d07861e09"
integrity sha512-p5XP8gcKqeozcJSPZS9ynVfuGV2rM9dYPCjL0GX7KRkjY9vpAO6IfDAFUbcJYbbwy54WiJqFjDMmm8xmTsVniQ==
dependencies:
"@percy/client" "1.6.1"
"@percy/config" "1.6.1"
"@percy/dom" "1.6.1"
"@percy/logger" "1.6.1"
"@percy/client" "1.6.4"
"@percy/config" "1.6.4"
"@percy/dom" "1.6.4"
"@percy/logger" "1.6.4"
content-disposition "^0.5.4"
cross-spawn "^7.0.3"
extract-zip "^2.0.1"
Expand All @@ -1400,25 +1400,25 @@
rimraf "^3.0.2"
ws "^8.0.0"

"@percy/dom@1.6.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/dom/-/dom-1.6.1.tgz#8b8e82817dd88f8497ffce2d8fc5480466cbfef3"
integrity sha512-TAVGiE/7imR3Q6z1ogZFufX+SsPrElBOYNmj+MOFVJyzJ/cTjA9B510Blx1nXTu2VNdK2GAmRGQPbZDty34YMg==

"@percy/env@1.6.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/env/-/env-1.6.1.tgz#5119de7526e006242b76688c24e94822113af139"
integrity sha512-AguYuqRcKHkCnWndvq1pTrxeUXT0mNULSi9p7D0nN1744036RcdVrE/EhZbgK2fshSHxIrnfPSj0Lnt4Of46lg==

"@percy/logger@1.6.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/logger/-/logger-1.6.1.tgz#754e3bdaa4419aadc2d7fa95b63f4ef757483cd4"
integrity sha512-cOMzDbg6Or1SnyzT9xCnwIiMDQ4sUR7Ha91CE6NWpV273Ef5PtvBA0joIB7wWSe7t2/a8hQrYJ6eGU4rUcsuTw==

"@percy/sdk-utils@^1.1.1":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@percy/sdk-utils/-/sdk-utils-1.6.1.tgz#257549ced3549188aebdb37ffb6e46f77dca77eb"
integrity sha512-H1a5UzlYYYUYj0I+hm3o1chgx1XMjTjeKHPneg25APfaDn5fCK1sm4xddurYFMk2sIv5Gxx8pvVMFSl4SlA/ZA==
"@percy/dom@1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/dom/-/dom-1.6.4.tgz#3a823b2138055ac4a0804d8802e849282adbebd7"
integrity sha512-1Ox++5ZpbleaERifm+NTgSgSWKpAFSIxd5x4ZUI6HzNlojDverat6nIFjU+q5Y4Y2DHXn5ihagvODqspOq0Dkw==

"@percy/env@1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/env/-/env-1.6.4.tgz#80cb8dd2b44cdce3318cdde752fc183a1553ffa5"
integrity sha512-zn/RqbxSOtSnV8rApLtJ7EVzFdPVv+Agwq85/UuTK+2Md5Eb+mnT6TbmkRg/0n7l8d14uiDcRRwRi1+msVefZg==

"@percy/logger@1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/logger/-/logger-1.6.4.tgz#598f1a5de0af9f8e3616a9d12ebf6fedbed5da78"
integrity sha512-lFPlVcxRtQyFw+TGzfOgFm4Vc/e8xx3nrrdKopnm22JIiTGH/hYFmq4A9u0e4b6Sp2nDZzWT2W5fxVHZiKDDlg==

"@percy/sdk-utils@^1.6.4":
version "1.6.4"
resolved "https://registry.yarnpkg.com/@percy/sdk-utils/-/sdk-utils-1.6.4.tgz#c5884dc3b4bf53354b02573b89e9cd945555d418"
integrity sha512-17bsvTiYzD/dmCJi5z2xh+usZOuIJ6AzxDRTplKGltFeSUr3t2rx33Z3lNoA33O/dCyl11eBK+p26p/Nwm87fQ==

"@simple-dom/interface@^1.4.0":
version "1.4.0"
Expand Down

0 comments on commit 858b94b

Please sign in to comment.