-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove @percy/agent as a dependency #243
Comments
@percy/agent
a dependency
Hey @chrisvdp! We actually plan on making this change to all of our SDKs in the next major release (along with other changes such as not automatically downloading Chromium on install). No exact timeline yet, but definitely soon! We'll leave this issue open until then for others asking the same. 👍 |
Great to hear. Thanks. |
@wwilsman Can you confirm this is solved with |
Hey @ctjhoa! That's correct -- I'll go ahead and close this issue out too 💯 |
Problem
@percy/agent
is quite a large download. Chromium itself is 130.3 Mb. This download is incurred by everyone who installsember-percy
, even though, in our case at least, the Percy agent is only ever invoked in ci. We would prefer to install the Percy agent either globally at each ci run, or as part of our docker container.Solution
Require users of
ember-percy
to also either add@percy/agent
to their package.json or install it globally.Note
This may also be a use case for peer dependencies, but it seems that this package does not require specific versions of the Percy agent.
The text was updated successfully, but these errors were encountered: