Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @percy/agent as a dependency #243

Closed
chrisvdp opened this issue Oct 8, 2020 · 4 comments
Closed

remove @percy/agent as a dependency #243

chrisvdp opened this issue Oct 8, 2020 · 4 comments

Comments

@chrisvdp
Copy link

chrisvdp commented Oct 8, 2020

Problem

@percy/agent is quite a large download. Chromium itself is 130.3 Mb. This download is incurred by everyone who installs ember-percy, even though, in our case at least, the Percy agent is only ever invoked in ci. We would prefer to install the Percy agent either globally at each ci run, or as part of our docker container.

Solution

Require users of ember-percy to also either add @percy/agent to their package.json or install it globally.

Note

This may also be a use case for peer dependencies, but it seems that this package does not require specific versions of the Percy agent.

@chrisvdp chrisvdp changed the title remove @percy/agent a dependency remove @percy/agent as a dependency Oct 8, 2020
@wwilsman
Copy link
Contributor

wwilsman commented Oct 9, 2020

Hey @chrisvdp!

We actually plan on making this change to all of our SDKs in the next major release (along with other changes such as not automatically downloading Chromium on install). No exact timeline yet, but definitely soon!

We'll leave this issue open until then for others asking the same. 👍

@chrisvdp
Copy link
Author

chrisvdp commented Oct 9, 2020

Great to hear. Thanks.

@ctjhoa
Copy link
Contributor

ctjhoa commented Jun 18, 2021

@wwilsman Can you confirm this is solved with @percy/ember@3.0.0 (#272) and percy-cli config
https://docs.percy.io/docs/skipping-asset-discovery-browser-download ?

@Robdel12
Copy link
Contributor

Hey @ctjhoa! That's correct -- I'll go ahead and close this issue out too 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants