Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for QUnit use #195

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Fix types for QUnit use #195

merged 2 commits into from
Apr 7, 2020

Conversation

erikkessler1
Copy link
Contributor

Problem

The tests introduced in #173 don't correctly reflect how you are supposed to import percySnapshot according to the docs.

This results in a type error when you try to use the function:

This expression is not callable.
Type 'typeof import(".../@percy/ember/types/index")' has no call signatures.

Solution

Export a default to match how the the function percySnapshot is exported from index.js.

Robdel12
Robdel12 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't really use TS so I'm flying blind on this one. I'm going to assume it works 👍 (the import was deff wrong, I should have caught that in #173)

@Robdel12 Robdel12 merged commit 5eed2e1 into percy:master Apr 7, 2020
@Robdel12
Copy link
Contributor

Robdel12 commented Apr 7, 2020

Thanks for the PR! 🔥

@erikkessler1 erikkessler1 mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robdel12 Robdel12 Robdel12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikkessler1 @Robdel12