Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for QUnit use #195

Merged
merged 2 commits into from
Apr 7, 2020
+2 −1
Merged

Fix types for QUnit use #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f1ec6e
Add a broken test
erikkessler1 Apr 7, 2020
77bea19
Add a default export
erikkessler1 Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type SnapshotFunction = (
) => Promise<void>;

export const percySnapshot: SnapshotFunction;
export default SnapshotFunction;

declare global {
// If QUnit types are present, the actual contents of its
Expand Down
2 changes: 1 addition & 1 deletion types/tests/qunit-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// of the library typechecks and invalid usage produces errors.

import { module, test } from 'qunit';
import { percySnapshot } from '@percy/ember';
import percySnapshot from '@percy/ember';

module('Type declarations with QUnit', function() {
test('snapshot requires at least one param', async function() {
Expand Down