Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency react-toastify to v10 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-toastify ^8.1.0 -> ^10.0.0 age adoption passing confidence

Release Notes

fkhadra/react-toastify (react-toastify)

v10.0.6

Compare Source

v10.0.5

Compare Source

v10.0.4

Compare Source

v10.0.3

Compare Source

v10.0.2

Compare Source

v10.0.1

Compare Source

v10.0.0

Compare Source

What is new in v10

The code for this release has been sitting on my computer for almost a year but with so many things going on it was hard for me to release it but it's finally there! A good chunk of the code has been rewritten, a bunch of bugs have been fixed. I've also addressed the oldest open feature request (Jan 10, 2020) 😆.

stacked

Screenshot 2023-12-17 at 14 53 50

Features

Play or pause the timer programmatically

By default, when the notification is hovered or the window loses focus, the timer for dismissing the notification is paused. There are many other situations where you might want to pause the timer as well. For instance, consider wanting to toggle the notification timer based on the document's visibility. This wasn't possible to do previously, but with the new API, it's a breeze.

document.addEventListener("visibilitychange", () => {
  if (document.visibilityState === "visible") {
    toast.play({ id: "123" });
  } else {
    toast.pause({ id: "123" });
  }
});

More usages:

  • Play/pause all toasts
toast.play()
toast.pause()
  • Play/pause all toasts for a given container
toast.play({ containerId: "123" })
toast.pause({ containerId: "123" })
  • Play/pause toast that has a given id regardless the container
toast.play({ id: "123" })
toast.pause({ id: "123" })
  • Play/pause toast that has a given id for a specific container
toast.play({ id: "123", containerId: "12" })
toast.pause({ id: "123", containerId: "12" })
Remove notification from a given container

This feature was the oldest one in the backlog (Jan 10, 2020). I don't know if the user who requested this feature is still using the library but I bet thanks to her/him, a bunch of user will be happy.

  • Remove all toasts that belongs to a given container
toast.dismiss({ container: "123" })
  • Remove toast that has a given id for a specific container
toast.dismiss({ id: "123", containerId: "12" })

The method is backward compatible. toast.dismis() and toast.dismiss("123") work as usual.

Check if a notification is active for a given container

You can limit the call to toast.isActive to a specific container.

  toast.isActive(toastId, containerId)
Better typescript inference when using data

When providing data to the notification, the content of data is correctly infered by typescript.

toast((props) => {
  return <div>{props.data.foo}</div>
},{
  data: {
    foo: "bar"
  }
})
IconProps now receives isLoading

When providing your own logic to display the icon, you now have access to the isLoading field.

const CustomIcon = props => {
  if (props.isLoading) return <Spinner />;

  switch (props.type) {
    case 'info':
      return <Info color={iconColor} />;
    case 'success':
      return <Success color={iconColor} />;
    case 'error':
      return <Error color={iconColor} />;
    case 'warning':
      return <Warning color={iconColor} />;
    default:
      return undefined;
  }
};

<ToastContainer icon={CustomIcon} />
Stacked Notifications

The initial release for this feature was planned right after the release of the v9. The code was their but things happen in life and I wasn't able to focus on the project that much.

That being said, I'm glad to finally release it.

stacked

To enable it, add the stacked prop to the ToastContainer. I also suggest to disable the progress bar :).

<ToastContainer stacked />
Progress bar background trail

The progress bar leaves a background trail by default.

Screenshot 2023-12-17 at 14 53 50

The opacity of the trail can be customized by overriding the css variable --toastify-color-progress-bgo.

  // disable the trail
  --toastify-color-progress-bgo: 0;

  // increase the opacity
  --toastify-color-progress-bgo: .8;

Breaking Changes

React 18 is the minimum required version, but...

The minimun version of react required is now 18. This version has been released for more than a year. Nextjs, react-query already did this move as well, so I believe it's a good time for the library as well.

That being said, I know that not all code base have the chance to be running on the latest version of react, so I'm considering to have a package for v17 if the demand is high enough.

The enableMultiContainer prop has been removed

The enableMultiContainer props is not needed anymore and has been removed. As long as your container has an id assigned then you are good to go.

// before
<ToastContainer id="myContainer" enableMultiContainer />

// now 🎉
<ToastContainer id="myContainer"  />
The toast.position and toast.type constants have been removed

The toast.POSITION and toast.TYPE constants have been removed. Typescript came a long way since the initial release of the library. The ecosystem has matured to a point where such constants are not needed anymore.

Change for some defaults

The closeOnClick prop is now false by default instead of true. When using the library I keep on turning this feature off which make me realize that it was not a good default in the first place. To turn it on do as follow

<ToastContainer closeOnClick />

The draggable prop is set to touch by default instead of true. Which means that, by default, notifications are only draggable on touch devices (most likely mobiles and tablets). While swipping a notification on mobile feels natural, dragging on desktop is not. If you want your notification to be draggable regardless of the device type just set draggable to true.

<ToastContainer draggable />

Bug Fixes and Chore

  • Remove defaultProps on ToastContainer as it's deprecated #​970
  • Fix className from ToastOptions overrides the toastClassName in ToastContainer props instead of appending #​956
  • Rewrite tests using component testing #​923
  • Memory leak while using multiple containers are goes on in v9.1.1 #​910
  • React toast is showing multiple time. #​744
  • onClose event trigger 2 times. #​741

v9.1.3

Compare Source

Release note

  • Add support for RSC (next app router): #​951
  • Partially address Toast is undefined || Uncaught TypeError: Cannot read properties of undefined (reading 'content') #​858 #​952
  • Bump dependencies

v9.1.2

Compare Source

Release notes

Mainly bug fixes as I'm working on the next major release.

🕷Bugfixes

v9.1.1

Compare Source

v9.1.0

Compare Source

Release notes

🚀 Features

  • toast.promise let you type data for each state. This is useful when rendering something based on the response.

For example:

interface Success {
  username: string
}

interface Error {
  err: string
}

toast.promise<Success,Error>(myPromise, {
  success: {
    render({ data }) {
      return data.username;
    }
  },
  error: {
    render({ data }) {
      return data.err;
    }
  }
})
  • toast.update accepts a generic as well to specify the data type
interface TData {
  username: string
}

toast.update<TData>(id, {
  data: payload,
  render({ data }) {
    return `hello ${data.username}`
  }
})

🕷 Bugfixes

  • fix progress countdown stops on mobile #​580
  • prevent clash with ios native gesture #​397
  • fix toast when a word is too long #​864
  • fix missing types declarations in exports #​843
  • fix toast.done not dismissing toast #​853
  • fix cursor when close on click is false #​839

🚨 Deprecated API

Added deprecation notice for the API below. They will be removed in the next major release

API Why Alternative
onClick Not used that much, it's increasing the API surface for nothing Can easily be implemented in userland. Just render a react component and attach the handler to it. toast(<div onClick={doSomething}>hello</div>)
onOpen Does not play well with useEffect behavior in react18 (runs twice in dev mode) see #​741 A better approach is to use toast.onChange see https://fkhadra.github.io/react-toastify/listen-for-changes/
onClose Does not play well with useEffect behavior in react18 (runs twice in dev mode) see #​741 A better approach is to use toast.onChange see https://fkhadra.github.io/react-toastify/listen-for-changes/
toast.POSITION Reduce bundle size :) Thanks to typescript, we now have autocomplete
toast.TYPE Reduce bundle size :) Thanks to typescript, we now have autocomplete

⚙️ Chore

  • bump dependencies
  • refactor internal

v9.0.8

Compare Source

Release notes

🐞Bugfixes

  • fix draggable in strict mode #​752
  • fix sass import #​771
  • fix progress bar overflow for WebKit browser(safari, ios...) #​791
  • fix dismissed toasts while the container is unmounted still appear when the container is mounted #​811
  • fix AutoClose doesn't work on update #​810 #​782 #​720

Chore

  • master branch renamed to main 💖

v9.0.7

Compare Source

Release note

Bugfix

Chore

  • build artifacts are no longer minified. This was causing issues with some bundlers like vitejs #​797

v9.0.6

Compare Source

Release note

Bugfix

  • fix missing generic in useNotificationCenter typing #​796

v9.0.5

Compare Source

Release note

🕷 Bugfix

  • inject-style has now the correct file-name in bundle #​779

v9.0.4

Compare Source

Release note

This release does not work with CRA v4(2 years old) due to the lack of support for es modules. I strongly advise to upgrade to lastest CRA if possible.
Alternative solution:

Bugfix

v9.0.3

Compare Source

Release notes

🕷 Bugfix

  • Fix icon not updating after calling toast.update #​770

v9.0.2

Compare Source

Release notes

Thanks to @​Rambatino, @​grit96, @​Vl3oss, @​eolme for this release

🕷 Bug fixes

  • typo #​764
  • pass toast styles through #​763
  • add function type in icon prop #​761
  • closeButton/icon types/rendering #​758
  • fix empty data object in NotificationCenter #​757

v9.0.1

Compare Source

v9.0.0

Compare Source

Release note
🚀 What is new in v9

Say hello to addons! What are addons? So, addons are like DLCs in video games but for react-toastify 😆. More seriously, you can think of it as utilities built around react-toastify. For example, custom theme, hooks, components etc...

useNotificationCenter

The first addon that I would like to introduce is the useNotificationCenter headless hook! As the name suggests, it let you build your notification center on top of react-toastify. See for yourself 👇

Screen.Recording.2022-05-03.at.21.24.02.mov

Another example using MUI.

Edit mui-notification-center
Check the documentation for more details.

Stacked toasts

This second addon will be released later. There are a bunch of details that I need to cover and I don't want to release something too buggy. Nevertheless, I'm really excited about it and I think it's worth showcasing anyway.

I call it StackedContainer for now, it's an alternative to the ToastContainer component.

stacked-container

💥 Breaking changes

There are 2 breaking changes. The API change for toast.onChange and the removal of toast.configure.

toast.onChange

The previous API was returning the numberOfToastDisplayed and the containerId. Honestly, this API seems to be incomplete.

For example, with the old API, if I wanted to do some logging this would be very difficult because I don't have enough data to log.

toast.onChange((numberOfToastDisplayed, containerId) => {
  logger.info("nothing useful to log, ...")
})

The new API offers more possibilities. The callback will receive a ToastItem. The item provides a bunch of useful properties status, content, id, data, etc...

interface ToastItem<Data = {}> {
    id: Id;
    content: React.ReactNode;
    theme?: Theme;
    type?: TypeOptions;
    isLoading?: boolean;
    containerId?: Id;
    data: Data;
    icon?: React.ReactNode | false;
    status: "added" | "removed" | "updated" 
}

const unsubscribe = toast.onChange((payload: ToastItem) => {
  switch (payload.status) {
    case "added":
      // new toast added
      break;
    case "updated":
      // toast updated
      break;
    case "removed":
      // toast has been removed
      break;
  }
});

For example, if I want to log something every time there is a new error notification, with the new API it's trivial

toast.onChange(payload => {
  if(payload.status === "added" && payload.type === toast.TYPE.ERROR) {
    logger.error({
      createdAt: Date.now(),
      content: payload.content,
      data: payload.data
    })
  }
})
toast.configure removal

toast.configure works fine for most cases but the current implementation has one main issue. It does not work with react context because it creates a new react tree.
That being said, having 2 APIs to do the same thing is a bad thing.

🕷 Bug fixes
  • #​725 the success toast on promise does not disappear when resolving too quickly
  • #​711 updated toast sometimes has wrong styles
  • #​700 generics are not used for toast.promise's result type if you use a custom render method

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants