Be robust towards invalid versions like "0.3.2d" (fixes #190) #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
reviewed
Oct 21, 2024
| v = parse(version) | ||
| try: | ||
| v = parse(version) | ||
| except InvalidVersion: |
Owner
There was a problem hiding this comment.
This needs a code-comment to explain why it's doing this.
I think you can take the title of this PR.
By the way, should it print a warning when it happens?
Collaborator
Author
There was a problem hiding this comment.
This needs a code-comment to explain why it's doing this. I think you can take the title of this PR.
@peterbe I can sure add an in-code comment: done.
By the way, should it print a warning when it happens?
I'm producing some output now. How do you feel about the new approach?
hartwork
force-pushed
the
issue-190-be-robust-towards-past-releases-with-invalid-versions
branch
3 times, most recently
from
941c10b to
8e9d68f
Compare
.. in past releases when trying to find the latest release
hartwork
force-pushed
the
issue-190-be-robust-towards-past-releases-with-invalid-versions
branch
from
8e9d68f to
f451e09
Compare
peterbe
approved these changes
Oct 21, 2024
hartwork
deleted the
issue-190-be-robust-towards-past-releases-with-invalid-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. in past releases when trying to find the latest release
Fixes #190
CC @peterbe