feat: remove npm bin (npm#5459)

BREAKING CHANGE: this removes the `npm bin` command The output of this command is misleading and incomplete. The `.bin` resolution of npm is much more nuanced than this command implies, and the output of `npm bin` is not something end users should be dealing with. `npm` itself is responsible for running the `bin` entries of modules, with the exception of global bins, which end up in the same folder as `node` itself, presumably already in a user's path since they can run node. Closes npm/statusboard#537
petershin · Sep 8, 2022 · 2e92800 · 2e92800
1 parent 412cbab
commit 2e92800
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 87 deletions.
diff --git a/lib/commands/bin.js b/lib/commands/bin.js
diff --git a/lib/utils/cmd-list.js b/lib/utils/cmd-list.js
@@ -74,7 +74,6 @@ const cmdList = [
   'access',
   'adduser',
   'audit',
-  'bin',
   'bugs',
   'cache',
   'ci',

diff --git a/smoke-tests/tap-snapshots/test/index.js.test.cjs b/smoke-tests/tap-snapshots/test/index.js.test.cjs
@@ -21,7 +21,7 @@ npm help npm       more involved overview
 
 All commands:
 
-    access, adduser, audit, bin, bugs, cache, ci, completion,
+    access, adduser, audit, bugs, cache, ci, completion,
     config, dedupe, deprecate, diff, dist-tag, docs, doctor,
     edit, exec, explain, explore, find-dupes, fund, get, help,
     hook, init, install, install-ci-test, install-test, link,

diff --git a/tap-snapshots/test/lib/commands/completion.js.test.cjs b/tap-snapshots/test/lib/commands/completion.js.test.cjs
@@ -47,7 +47,6 @@ Array [
       access
       adduser
       audit
-      bin
       bugs
       cache
       ci

diff --git a/tap-snapshots/test/lib/load-all-commands.js.test.cjs b/tap-snapshots/test/lib/load-all-commands.js.test.cjs
@@ -57,18 +57,6 @@ Options:
 Run "npm help audit" for more info
 `
 
-exports[`test/lib/load-all-commands.js TAP load each command bin > must match snapshot 1`] = `
-Display npm bin folder
-
-Usage:
-npm bin
-
-Options:
-[-g|--global]
-
-Run "npm help bin" for more info
-`
-
 exports[`test/lib/load-all-commands.js TAP load each command birthday > must match snapshot 1`] = `
 Birthday, deprecated
 

diff --git a/tap-snapshots/test/lib/npm.js.test.cjs b/tap-snapshots/test/lib/npm.js.test.cjs
@@ -21,7 +21,7 @@ npm help npm       more involved overview
 
 All commands:
 
-    access, adduser, audit, bin, bugs, cache, ci, completion,
+    access, adduser, audit, bugs, cache, ci, completion,
     config, dedupe, deprecate, diff, dist-tag, docs, doctor,
     edit, exec, explain, explore, find-dupes, fund, get, help,
     hook, init, install, install-ci-test, install-test, link,
@@ -57,7 +57,7 @@ npm help npm       more involved overview
 
 All commands:
 
-    access, adduser, audit, bin, bugs, cache, ci, completion,
+    access, adduser, audit, bugs, cache, ci, completion,
     config, dedupe, deprecate, diff, dist-tag, docs, doctor,
     edit, exec, explain, explore, find-dupes, fund, get, help,
     hook, init, install, install-ci-test, install-test, link,
@@ -93,7 +93,7 @@ npm help npm       more involved overview
 
 All commands:
 
-    access, adduser, audit, bin, bugs, cache, ci, completion,
+    access, adduser, audit, bugs, cache, ci, completion,
     config, dedupe, deprecate, diff, dist-tag, docs, doctor,
     edit, exec, explain, explore, find-dupes, fund, get, help,
     hook, init, install, install-ci-test, install-test, link,
@@ -129,7 +129,7 @@ npm help npm       more involved overview (in a browser)
 
 All commands:
 
-    access, adduser, audit, bin, bugs, cache, ci, completion,
+    access, adduser, audit, bugs, cache, ci, completion,
     config, dedupe, deprecate, diff, dist-tag, docs, doctor,
     edit, exec, explain, explore, find-dupes, fund, get, help,
     hook, init, install, install-ci-test, install-test, link,
@@ -211,16 +211,6 @@ All commands:
                     
                     Run "npm help audit" for more info
 
-    bin             Display npm bin folder
-                    
-                    Usage:
-                    npm bin
-                    
-                    Options:
-                    [-g|--global]
-                    
-                    Run "npm help bin" for more info
-
     bugs            Report bugs for a package in a web browser
                     
                     Usage:

diff --git a/tap-snapshots/test/lib/utils/cmd-list.js.test.cjs b/tap-snapshots/test/lib/utils/cmd-list.js.test.cjs
@@ -30,8 +30,7 @@ Object {
     "auth": "author",
     "autho": "author",
     "author": "author",
-    "bi": "bin",
-    "bin": "bin",
+    "b": "bugs",
     "bu": "bugs",
     "bug": "bugs",
     "bugs": "bugs",
@@ -418,7 +417,6 @@ Object {
     "access",
     "adduser",
     "audit",
-    "bin",
     "bugs",
     "cache",
     "ci",

diff --git a/test/lib/commands/bin.js b/test/lib/commands/bin.js