Verify that the pgrx active thread is actually the main thread #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
approved these changes
Oct 10, 2023
Comment on lines
+56
to
+60
| // Note that this returns `-1` in some error conditions. | ||
| // | ||
| // In these cases we are almost certainly not the main thread, but | ||
| // we don't know -- it's better for this function to return `None` | ||
| // in cases of uncertainty. |
There was a problem hiding this comment.
They claim this is about the thread not finishing initialization? https://opensource.apple.com/source/libpthread/libpthread-218.1.3/man/pthread_main_np.3.auto.html
| //! this by remembering the first thread to call into postgres functions, and | ||
| //! panicking if we're called from a different thread. | ||
| //! this by remembering the first thread to call into postgres functions (the | ||
| //! "active thread" in some comments), and panicking if we're called from a |
There was a problem hiding this comment.
and also the big static ACTIVE_THREAD.... ^^;
workingjubilee
merged commit b71006c
into
pgcentralfoundation:develop
17 of 18 checks passed
|
cc @LuminousMonkey By the way, is there something more clever we could be doing here for illumos? |
|
@workingjubilee Sorry, I'm not sure to be honest. I only knew the one change I had to do so I could complete it on a Illumos machine. My working knowledge of things like this is minimal at best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrelated to my other work, but this has bugged me for a while and I figured I'd fix it.