Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation on emscripten #1917

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Oct 12, 2024

No description provided.

@usamoi
Copy link
Contributor Author

usamoi commented Oct 12, 2024

Notes for someone who is interested in this.

Examples in pgrx-examples work with pglite if the following is set correctly:

  1. rustc flag -Clink-arg=-sSIDE_MODULE=2
  2. environment variable BINDGEN_EXTRA_CLANG_ARGS_wasm32_unknown_emscripten="-isystem /home/usamoi/.emscripten_cache/sysroot/include/fakesdl -isystem /home/usamoi/.emscripten_cache/sysroot/include/compat -isystem /opt/emscripten-llvm/lib/clang/20/include -isystem /home/usamoi/.emscripten_cache/sysroot/include -fvisibility=default" set (you can find these paths by emcc test.c --verbose)
  3. environment variable PGRX_BINDGEN_NO_DETECT_INCLUDES=1
  4. add needed emscripten/postgres symbols in pglite (see add symbols needed by pgrx usamoi/pglite#2).
  5. cargo flag --features pgrx/cshim

Known issues:

  1. _emscripten_memcpy_js is needed by the environment (but it does not emit errors util this symbol is used at run-time, and I'm not sure if it could be solved by adding rustc flags -Ctarget-feature=+bulk-memory and -Clink-arg=-mbulk-memory)

PGRX does not support running on emscripten and pglite does not support loading pgrx extensions officially. So there could be more potential bugs and you can not expect it works without your extra efforts.

@eeeebbbbrrrr eeeebbbbrrrr merged commit 9938e0d into pgcentralfoundation:develop Oct 14, 2024
14 checks passed
eeeebbbbrrrr added a commit that referenced this pull request Oct 14, 2024
Welcome to pgrx v0.12.6. This releases fixes a number of bugs, cleans up
various parts of the code, adds more Postgres `#include` headers, and
other little things.

To upgrade, first install cargo-pgrx with `cargo install cargo-pgrx
--version 0.12.6 --locked`. Then you can run `cargo pgrx upgrade` in
your extension's crate to update its dependencies.

## What's Changed
* Removed extra allocation from `IntoDatum for char` by @YohDeadfall in
#1887
* Fixed IntoDatum impl for char introduced by #1887 by @YohDeadfall in
#1889
* Support refs to unsized SqlTranslatable types by @workingjubilee in
#1890
* Nullable is Copy when T is Copy by @workingjubilee in
#1884
* Macro based IntoDatum for string types by @YohDeadfall in
#1886
* `impl FromDatum for CString` by @workingjubilee in
#1896
* Add `BorrowDatum` for unsizing borrows of datums by @workingjubilee in
#1891
* Always panic if len of varlena exceeds the maximum by @YohDeadfall in
#1894
* Use cstr literal syntax to avoid unsafe and ??? by @workingjubilee in
#1898
* Implement UnboxDatum for ItemPointerData by @syvb in
#1900
* fix compilation on some CPUs and Windows by @usamoi in
#1901
* docs: update generic type name of TableIterator by @SteveLauC in
#1905
* Remove Python workaround for Homebrew by @workingjubilee in
#1908
* Improved messages for json errors by @YohDeadfall in
#1893
* Adds more headers by @aykut-bozkurt in
#1910
* docs: align description of GucContext::SuBackend and
GucContext::Backend with original PostgreSQL description by @mrl5 in
#1909
* docs: update outdated README by @SteveLauC in
#1914
* fix compilation on emscripten by @usamoi in
#1917
* feat: include 'storage/indexfsm.h' by @SteveLauC in
#1912
* refactor: more CStr literals by @SteveLauC in
#1911
* fix segfault with empty `numrange` during `from_datum()` by
@eeeebbbbrrrr in #1918

## New Contributors
* @mrl5 made their first contribution in
#1909

**Full Changelog**:
v0.12.5...v0.12.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants