-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples table metadata fields toggle #348
Conversation
5053242
to
d4d11ea
Compare
@joshsadam Still need to review the code but just had one comment after manually testing. If we select a metadata template and then transfer a sample, when the samples table reloads upon success, the metadata template that was applied is no longer set, and the table defaults to the columns without the metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good just a couple of comments below for the seed data and testing
eb24a15
to
e73b76f
Compare
385719b
to
1aeade3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment below to move some methods into the application_controller
6e569a6
to
dcbb21f
Compare
dcbb21f
to
7a66add
Compare
3afdfa7
to
f5ad7a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works as expected!
What does this PR do and why?
Describe in detail what your merge request does and why.
Updated both Project > Sample and Group > Samples pages to include a toggle that, when on, will display all metadata fields for the displayed samples.
Resolves #281
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Metadata toggle
Table with selected fields
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.