Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Multiple times tag->title()->prepend() do not make title what i expect #16283

Closed
borisdelev opened this issue Feb 20, 2023 · 1 comment · Fixed by #16284
Closed

[BUG]: Multiple times tag->title()->prepend() do not make title what i expect #16283

borisdelev opened this issue Feb 20, 2023 · 1 comment · Fixed by #16284
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@borisdelev
Copy link
Contributor

Issue
When i use multiple times tag->title()->prepend() results its not what i expect. Will make it clear with example

Example

 $this->tag->title()->set('Start')->setSeparator(' - '); // Title will be just "Start"
 $this->tag->title()->prepend('Category'); // Title now will be "Category - Start"
 $this->tag->title()->prepend('Product'); // Title now will be "Category - Product - Start" ... and here is my issue

Expected behavior
If i use prepend more than once, still need prepend items:

 $this->tag->title()->set('Start')->setSeparator(' - '); // Title will be just "Start"
 $this->tag->title()->prepend('Category'); // Title now will be "Category - Start"
 $this->tag->title()->prepend('Product'); // MUST BE "Product - Category - Start"

Details

  • Phalcon version: 5.1.4
  • PHP Version: 8.1.11
  • Operating System: Windows
  • Installation type: DLL
  • Server: Apache

Well... this is it. If you think my expectation is wrong behavior- okay, just need to know.

Thanks guys :) u great

@borisdelev borisdelev added bug A bug report status: unverified Unverified labels Feb 20, 2023
@borisdelev borisdelev changed the title [BUG]: Tag multiple times tag->title()->prepend() do not make title what i expect [BUG]: Multiple times tag->title()->prepend() do not make title what i expect Feb 20, 2023
@niden niden self-assigned this Feb 20, 2023
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Feb 20, 2023
@niden niden added this to Phalcon v5 Feb 20, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Phalcon v5 Feb 20, 2023
@niden niden moved this from Backlog to Active Sprint in Phalcon v5 Feb 20, 2023
@niden niden moved this from Active Sprint to In Progress in Phalcon v5 Feb 20, 2023
@niden niden mentioned this issue Feb 20, 2023
5 tasks
@niden niden linked a pull request Feb 20, 2023 that will close this issue
5 tasks
@borisdelev
Copy link
Contributor Author

It looks like u fix that and maybe this is the right behaviour.

Thank you! A lot... cant wait v6. Then i can be better support-er :)

Wish u great day!

@github-project-automation github-project-automation bot moved this from In Progress to Implemented in Phalcon v5 Feb 24, 2023
@niden niden moved this from Implemented to Released in Phalcon v5 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants