Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16171 config insensitive #16172

Merged
merged 3 commits into from
Oct 19, 2022
Merged

T16171 config insensitive #16172

merged 3 commits into from
Oct 19, 2022

Conversation

niden
Copy link
Member

@niden niden commented Oct 19, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Config\Config::setData to pass the insensitive flag to child objects
Fixed Phalcon\Config\Adapter\Groupped::__construct to pass the insensitive flag to child objects

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Oct 19, 2022
@niden niden requested a review from Jeckerson October 19, 2022 18:17
@niden niden self-assigned this Oct 19, 2022
@niden niden linked an issue Oct 19, 2022 that may be closed by this pull request
[BUG]: Phalcon\Config created by Phalcon\Config should keep insensitive choice #16171
Closed
@niden niden merged commit ab001b7 into phalcon:5.0.x Oct 19, 2022
@niden niden deleted the T16171-config-insensitive branch October 19, 2022 18:43
@niden niden mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Config created by Phalcon\Config should keep insensitive choice
2 participants
@niden @Jeckerson