Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16177 - Unify args of fetchAll() with PDOStatement::fetchAll() #16178

Merged
merged 6 commits into from
Oct 24, 2022
Merged

#16177 - Unify args of fetchAll() with PDOStatement::fetchAll() #16178

merged 6 commits into from
Oct 24, 2022

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Oct 24, 2022 •
edited by niden
Loading

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Thanks

@Jeckerson Jeckerson added bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Oct 24, 2022
@Jeckerson Jeckerson self-assigned this Oct 24, 2022
@Jeckerson Jeckerson requested a review from niden October 24, 2022 13:42
@Jeckerson Jeckerson linked an issue Oct 24, 2022 that may be closed by this pull request
[BUG]: PdoResult::fetchAll() does not accept string for class name in FETCH_CLASS mode #16177
Closed
@niden niden added the status: high High label Oct 24, 2022
@Jeckerson Jeckerson marked this pull request as ready for review October 24, 2022 16:02
@Jeckerson Jeckerson merged commit a4eb3b4 into 5.0.x Oct 24, 2022
@Jeckerson Jeckerson deleted the #16177-fetchAll branch October 24, 2022 16:03
@niden niden mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: PdoResult::fetchAll() does not accept string for class name in FETCH_CLASS mode
2 participants
@Jeckerson @niden