Do not use lifetime option as Redis connection timeout #16447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misantron You probably want to put this to phalcon 5 branch not 4. |
|
@rudiservo no, there is no issue at version 5 |
|
I am going to try and rebase this to 4.2.x |
…ameters are not passed
niden
force-pushed
the
redis-timeout-option
branch
from
b650b6c
to
f6135d4
Compare
niden
approved these changes
Jan 11, 2024
|
Thank you @misantron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Redis cache adapter: using new
timeoutoption with Redis connection instead oflifetimeThanks