Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#16606] - feat: added events and events manager to storage and cache classes #16607

Merged

Conversation

noone-silent
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change: See title

Thanks

@noone-silent
Copy link
Contributor Author

This is the first implementation. Currently we have to add it to every class. I will refactor it later so that Phalcon\Storage\AbstractAdapter holds all the methods (decrement, increment, etc) and calls the doXXX() method of the class, like it is currently with the get() method.

New implementations of a Cache class would so have automatically all events.

phalcon/Cache/AbstractCache.zep Outdated Show resolved Hide resolved
phalcon/Cache/AbstractCache.zep Outdated Show resolved Hide resolved
@niden niden merged commit fbb8318 into phalcon:5.0.x Jun 8, 2024
50 checks passed
@niden
Copy link
Member

niden commented Jun 8, 2024

Thank you @noone-silent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants