Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-97: Renaming column does not drops column on morphTable #123

Merged

Conversation

BeMySlaveDarlin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
During table morphing, if table column was just renamed, it will drop it and add new one, which will cause data loss.

Changed behavior to checking field meta and neighbours to process correct morphing

Thanks

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #123 (1b6b57d) into master (0e76b22) will increase coverage by 1.52%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     56.20%   57.72%   +1.52%     
- Complexity      529      550      +21     
============================================
  Files            21       22       +1     
  Lines          1482     1533      +51     
============================================
+ Hits            833      885      +52     
+ Misses          649      648       -1     

@Jeckerson Jeckerson linked an issue Aug 11, 2021 that may be closed by this pull request
@Jeckerson Jeckerson added the bug Something isn't working label Aug 11, 2021
@Jeckerson Jeckerson added this to the 2.2.x milestone Aug 11, 2021
@Jeckerson Jeckerson merged commit 70e50f8 into phalcon:master Aug 11, 2021
@BeMySlaveDarlin BeMySlaveDarlin deleted the renaming-column-on-morph-table branch September 4, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change column modification behaviour during table morph
2 participants