Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compiled method installation code from compile to install step #17469

Open
wants to merge 1 commit into
base: Pharo12
Choose a base branch
from

Conversation

guillep
Copy link
Member

@guillep guillep commented Nov 29, 2024

The compile step tries to fill a method with metadata existing on installed methods.
Fetching this existing method and filling the meta-data should be done at the installation step and not the compilation step.

This is important for the bootstrap step, where no prior method exists, and no prior class to look for is there either.

@MarcusDenker
Copy link
Member

fails with which I think is not caused by this PR:

SystemNotification: Loading Compression-tonel.1.mcz
[547](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-547)
KeyNotFound: key #unzipped not found in MethodDictionary
[548](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-548)
MethodDictionary(Dictionary)>>errorKeyNotFound:
[549](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-549)
[self errorKeyNotFound: key] in MethodDictionary(Dictionary)>>at: in Block: [self errorKeyNotFound: key]
[550](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-550)
MethodDictionary>>at:ifAbsent:
[551](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-551)
MethodDictionary(Dictionary)>>at:
[552](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-17469/1/pipeline-console/?start-byte=0&selected-node=26#log-552)
ByteArray class(Behavior)>>compiledMethodAt:

@MarcusDenker
Copy link
Member

Ah, this is Pharo12, I added an issue: #17472

@MarcusDenker
Copy link
Member

So the Problem

KeyNotFound: key #unzipped not found in MethodDictionary"

Is indeed caused by this PR

@guillep
Copy link
Member Author

guillep commented Dec 2, 2024

I'll check it during the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants