fix-SDL-default-renderer-by-platform #17517
Open
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MacOS, the SDL_RENDERER_PRESENTVSYNC is needed when using 4k monitors. pharo-project#17439 In Windows having this flag produces crashes.
guillep
reviewed
Dec 13, 2024
guillep
reviewed
Dec 13, 2024
guillep
approved these changes
Dec 13, 2024
Co-authored-by: Guille Polito <guillermopolito@gmail.com>
Co-authored-by: Guille Polito <guillermopolito@gmail.com>
astares
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default renderer flags should be different by platforms.
In MacOS, the SDL_RENDERER_PRESENTVSYNC is needed when using 4k monitors. #17439 In Windows having this flag produces crashes.