Skip to content

Conversation

@tekante
Copy link
Member

@tekante tekante commented Apr 30, 2023

Description

Further enhancements for local development and addition of successful project creation via ability to run yarn build and yarn storybook:build within the project. This also has changes to test for successful project initiation in CI. See https://github.com/phase2/outline/actions/runs/4846186198 for example of a full successful run.

This builds on work from branch feature/docs-and-init-dx so I'm setting that as the target at the moment to make it easier to review what has changed since then.

Once #380 merges this can be targeted at the next branch for merging though note that the changes in #385 are needed for full successful CI.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual Testing
  • Automated Testing
  • Accessibility Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

tekante added 2 commits April 30, 2023 10:43
Adding a script to link all packages into a generated project
when the local flag is used.
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2023

⚠️ No Changeset found

Latest commit: 787cad8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tekante tekante changed the base branch from feature/docs-and-init-dx to next April 30, 2023 15:10
@tekante tekante changed the base branch from next to feature/docs-and-init-dx April 30, 2023 15:11
@tekante tekante marked this pull request as ready for review April 30, 2023 15:12
@tekante tekante changed the base branch from feature/docs-and-init-dx to next April 30, 2023 15:12
@tekante tekante changed the base branch from next to feature/docs-and-init-dx April 30, 2023 15:14
@socket-security
Copy link

socket-security bot commented Apr 30, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@phase2/outline-form@0.0.6 None +0 himerus

Copy link
Contributor

@shaal shaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekante thank you!

Copy link
Contributor

@himerus himerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may have some other options here. I've really got to dive further into the details here and what turborepo should be doing for us by default.

@himerus himerus marked this pull request as draft May 18, 2023 17:23
@tekante tekante mentioned this pull request May 20, 2023
15 tasks
@tekante tekante marked this pull request as ready for review May 20, 2023 02:44
Base automatically changed from feature/docs-and-init-dx to next May 22, 2023 13:18
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for outlinejs ready!

Name Link
🔨 Latest commit 787cad8
🔍 Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/646b7a2aeb20f2000860cfad
😎 Deploy Preview https://deploy-preview-384--outlinejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@himerus himerus merged commit 10bc1c2 into next May 22, 2023
@himerus himerus deleted the feature/local-dev-dx branch May 22, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants