Fixes uses of type :str = None to be :Optional[str] = None #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-chaturvedi
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
@drcongo Thanks for the fix, and for cleaning up the imports too!
This lgtm, @nimish-ks could you give this a once-over too?
nimish-ks
approved these changes
Nov 20, 2024
|
cheers 🍻 @drcongo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to the typing, wherever
:str = Noneis used thestrtype needs to be wrapped inOptionalasNoneis not a string. This fixes it for users who run tools likeTypeguard.