Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json data with dataKey in Pack loader #6001

Closed
rexrainbow opened this issue Feb 12, 2022 · 2 comments
Closed

Use json data with dataKey in Pack loader #6001

rexrainbow opened this issue Feb 12, 2022 · 2 comments

Comments

@rexrainbow
Copy link
Contributor

Version

  • Phaser Version: 3.55.2
  • Operating system: win11
  • Browser: Chrome. firefox

Description

Here is the test code. It load assets by Pack with json data.

  • Without dataKey, it works fiine
  • With datakey test1, it won't work.

It might because that, redundant reading dataKey in JSONFile loader, therefore this.data will be incorrect.

@photonstorm
Copy link
Collaborator

Hmm... removing this this.data = GetValue(url, dataKey); fixes load.pack and breaks load.json :)

Will dig a little deeper.

@photonstorm
Copy link
Collaborator

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants