Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDefinedClass.getMethod does not work when a parameter is JDirectClass #58

Closed
fbaro opened this issue Dec 13, 2017 · 1 comment
Closed

JDefinedClass.getMethod does not work when a parameter is JDirectClass #58

fbaro opened this issue Dec 13, 2017 · 1 comment
Assignees
@phax
Labels
enhancement

Comments

@fbaro
Copy link
Contributor

fbaro commented Dec 13, 2017

The JDefinedClass.getMethod() method works by searching a method with matching name and parameter types. As JDirectClass does not implement the equals method, if getMethod() is provided with a JDirectClass freshly obtained from JCodeModel.ref(), it will not return the required method.
fbaro pushed a commit to fbaro/jcodemodel that referenced this issue Dec 13, 2017
Fix for phax#58: implement equals() in JDirectClass
fddff6c
@phax phax self-assigned this Dec 13, 2017
phax added a commit that referenced this issue Dec 13, 2017
@phax
Merge pull request #59 from fbaro/master
7782312 
Test & proposed fix for #58
phax added a commit that referenced this issue Dec 13, 2017
@phax
Further adoption for #58
0c16e7e
@phax
Copy link
Owner

phax commented Dec 13, 2017

Thanks for this. I added hashCode

@phax phax closed this as completed Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @fbaro