Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for issue #61 #62

Merged
merged 2 commits into from
May 9, 2018
Merged

Proposed fix for issue #61 #62

merged 2 commits into from
May 9, 2018

Conversation

fbaro
Copy link
Contributor

@fbaro fbaro commented May 9, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #62 into master will increase coverage by 0.52%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     36.58%   37.11%   +0.52%     
- Complexity      828      840      +12     
============================================
  Files           120      120              
  Lines          5144     5146       +2     
  Branches        745      745              
============================================
+ Hits           1882     1910      +28     
+ Misses         3020     2996      -24     
+ Partials        242      240       -2
Impacted Files Coverage Δ Complexity Δ
...a/com/helger/jcodemodel/fmt/JSerializedObject.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/com/helger/jcodemodel/fmt/JTextFile.java 78.57% <100%> (+78.57%) 3 <0> (+3) ⬆️
src/main/java/com/helger/jcodemodel/JPackage.java 45.38% <0%> (+5.38%) 26% <0%> (+2%) ⬆️
...lger/jcodemodel/writer/SingleStreamCodeWriter.java 94.11% <0%> (+23.52%) 8% <0%> (+4%) ⬆️
...a/com/helger/jcodemodel/AbstractJResourceFile.java 100% <0%> (+100%) 3% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd9183...1e91d0e. Read the comment docs.

@phax phax merged commit 9da04c8 into phax:master May 9, 2018
phax added a commit that referenced this pull request Aug 22, 2018
phax added a commit that referenced this pull request Aug 22, 2018
@amilajayasooriya
Copy link

Hi,
I have noticed from this fix on wards JBlock invoke method does not return JInnovation object to set arguments. Previously I used to set arguments as

.body() .invoke("methodToCall").arg(varRepository).arg(varService);

Could kindly provide example how to pass arguments to method invoke in version?

Thanks
Amila

@phax
Copy link
Owner

phax commented Jul 3, 2020

Hi,
please ue the following code instead:

.body ().add (JExpr.invoke ("methodToCall").arg (varRepository).arg(varService));

hth

@amilajayasooriya
Copy link

Hi,
please ue the following code instead:

.body ().add (JExpr.invoke ("methodToCall").arg (varRepository).arg(varService));

hth

Thank you very much Phax for quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants