Ensure ReplicationStreamer is always started when replication enabled. (

matrix-org#7579) Fixes matrix-org#7566.
phil-flex · Jun 16, 2020 · 8edacc9 · 8edacc9
1 parent 76e2124
commit 8edacc9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/changelog.d/7579.bugfix b/changelog.d/7579.bugfix
@@ -0,0 +1 @@
+Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1.
diff --git a/synapse/replication/tcp/handler.py b/synapse/replication/tcp/handler.py
@@ -136,6 +136,9 @@ def start_replication(self, hs):
                 hs.config.redis_port,
             )
 
+            # First let's ensure that we have a ReplicationStreamer started.
+            hs.get_replication_streamer()
+
             # We need two connections to redis, one for the subscription stream and
             # one to send commands to (as you can't send further redis commands to a
             # connection after SUBSCRIBE is called).
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1.