From 7f0c2537d22ef3fee323140c3c07295c71aad6ba Mon Sep 17 00:00:00 2001 From: Christian Ebert Date: Fri, 12 May 2023 15:23:51 +0100 Subject: [PATCH] fix: time tooltip out of bounds on the right This revives https://github.com/videojs/video.js/pull/7308 The analysis by @PikachEXE https://github.com/videojs/video.js/issues/7248#issuecomment-873876011 still stands. However, the alignment issues pointed out in https://github.com/videojs/video.js/pull/7308#issuecomment-888622689 cannot be reproduced with the current Video.js v8.x and v7.x versions after the patch is applied. --- src/js/control-bar/progress-control/progress-control.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/control-bar/progress-control/progress-control.js b/src/js/control-bar/progress-control/progress-control.js index a2d1e64d94..7ee3a7bdfb 100644 --- a/src/js/control-bar/progress-control/progress-control.js +++ b/src/js/control-bar/progress-control/progress-control.js @@ -72,7 +72,7 @@ class ProgressControl extends Component { } const seekBarEl = seekBar.el(); - const seekBarRect = Dom.findPosition(seekBarEl); + const seekBarRect = Dom.getBoundingClientRect(seekBarEl); let seekBarPoint = Dom.getPointerPosition(seekBarEl, event).x; // The default skin has a gap on either side of the `SeekBar`. This means