From 3fde7120ec005cc10ed7bb93695fb3f24afc813e Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 7 Nov 2023 14:20:51 +0900 Subject: [PATCH] Fix a few node tests --- .github/workflows/main.yml | 6 ++++-- scripts/bootstrap.js | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d515095..efd68df 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -72,8 +72,10 @@ jobs: cd node ../out/Release/node_cctest ../out/Release/node test/embedding/test-embedding.js - # TODO(zcbenz): Fix the tests. - ./tools/test.py --shell ../out/Release/node --flaky-tests=dontcare --skip-tests=parallel/test-crypto-no-algorithm,parallel/test-process-versions,parallel/test-snapshot-basic + # TODO(zcbenz): The parallel/test-crypto-no-algorithm test is failing, + # which was introduced by https://github.com/nodejs/node/pull/46237, I + # don't have enough experience with OpenSSL to fix it. + ./tools/test.py --shell ../out/Release/node --flaky-tests=dontcare --skip-tests=parallel/test-crypto-no-algorithm vs-toolchain: runs-on: windows-2022 diff --git a/scripts/bootstrap.js b/scripts/bootstrap.js index 350080d..b18bec3 100755 --- a/scripts/bootstrap.js +++ b/scripts/bootstrap.js @@ -37,6 +37,9 @@ const commonConfig = [ 'v8_promise_internal_field_count=1', 'v8_scriptormodule_legacy_lifetime=true', 'v8_enable_maglev=false', + // TODO(zcbenz): Node.js manually updates this value in common.gypi, we should + // find out a better procedure without manual updating source code. + 'v8_embedder_string="-node.0"', // Not our job fixing the warnings. 'clang_use_chrome_plugins=false', ]