AMQPMessage::basic_consume + $nowait=null results in $nowait=true

[jamarr81]

This is a minor, but annoying, bug. Basically, if $nowait=null is given to AMQPMessage::basic_consume, it's treated as if $nowait=true. It should be treated as $nowait=false.

The problem is that basic_consume uses the identity operator (===) instead of the equality operator (==) when checking $nowait on line 397.

[michaelklishin]

Why do you think so? It's not unreasonable for a library to default to true. I'm hardly a PHP expert but as a maintainer of many client libraries I'd certainly treat null as "use a default value", not necessarily false.

[jamarr81]

In PHP it is an unwritten standard that null values always be treated as falsy when checking for a boolean result; mainly because PHP specifies this definition via type juggling semantics.

That said, the identity (===) operator's main use is to determine if two objects are in fact the same instance of a class...where as the equality (==) operator's main use is to determine if two objects or values are equivalent (but not necessarily the same 'instance').

Finally, in this specific case, the default parameter value for $nowait (in AMQPMessage::basic_consume) is false...so even if we ignore all of the above, it still makes sense for null to be equated as false using your logic ;)

[hairyhum]

The function API suggests you use a boolean value, not null or even an object (which could be set to null). Implicit type conversions in PHP are hard enough to add additional complexity by two falsy values explicitly in the library code.
Instead, for my opinion, type check should throw an exception if an invalid parameter value is supplied.

[ramunasd]

$nowait must be boolean, either true or false. In next major release we will add typehints and any non boolean argument just wont work.