Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate real exceptions #976

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

dmitryuk
Copy link
Contributor

The pr adds real exceptions to target method AbstractConnection::channel.

Developer will can understand transparently that method channel can throw AMQPTimeoutException,AMQPConnectionClosedException and do reconnect

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #976 (2cbd008) into master (97175f5) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #976      +/-   ##
============================================
- Coverage     72.58%   72.40%   -0.19%     
- Complexity      887      900      +13     
============================================
  Files            31       33       +2     
  Lines          2488     2522      +34     
============================================
+ Hits           1806     1826      +20     
- Misses          682      696      +14     
Impacted Files Coverage Δ
PhpAmqpLib/Channel/AMQPChannel.php 53.22% <ø> (ø)
PhpAmqpLib/Channel/AbstractChannel.php 70.05% <ø> (ø)
PhpAmqpLib/Connection/AbstractConnection.php 74.61% <ø> (-0.51%) ⬇️
PhpAmqpLib/Wire/IO/AbstractIO.php 81.96% <0.00%> (-13.12%) ⬇️
...mqpLib/Connection/Heartbeat/SIGHeartbeatSender.php 90.62% <0.00%> (ø)
...ection/Heartbeat/AbstractSignalHeartbeatSender.php 75.00% <0.00%> (ø)
...pLib/Connection/Heartbeat/PCNTLHeartbeatSender.php 100.00% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97175f5...2cbd008. Read the comment docs.

@ramunasd ramunasd added this to the 3.2.0 milestone Feb 15, 2022
@ramunasd ramunasd merged commit 6f1544b into php-amqplib:master Feb 15, 2022
kratkyzobak pushed a commit to kratkyzobak/php-amqplib that referenced this pull request Feb 9, 2024
* Propagate real exceptions

Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants