Support azjezz/psl 2.x (keep supporting 1.x) #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for the pr! The idea is to go all in on PSL 2 and bumping the supported php versions to php8.1+8.2 over all packages inside php-soap. Since PSL 1 is completely different from PSL 2, I don't want to take the extra maintenance burden to support both. |
|
Hi @veewee, so should I just drop the PSL 1 checks and use PSL 2 only? Is there a branch we could merge this to, or should we wait a bit? |
|
That is indeed the idea, but it requires all dependant packages to go that way as well. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to PSL 2.x without dropping support for 1.x.
Please let me know if this would be an acceptable solution and I'll be happy to make it cleaner if you like :)