Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Add errors for curl_multi_select #3965

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[PHP 8.4] Add errors for curl_multi_select #3965

merged 2 commits into from
Nov 14, 2024

Conversation

saundefined
Copy link
Member

No description provided.

@saundefined saundefined added this to the PHP 8.4 milestone Oct 29, 2024
@saundefined saundefined mentioned this pull request Oct 29, 2024
Open
Girgias
Girgias reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make more sense to create a <?phpdoc instructor to generate these sorts of messages.

These seem to only be used by PhD, but surely one could "resolve" them in the configure.php script

@saundefined @Girgias
Apply suggestions from code review
e489662 
Co-authored-by: Gina Peter Banyard <girgias@php.net>
This was referenced Oct 29, 2024
Open
Open
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 7, 2024
Open
@Girgias Girgias merged commit f414967 into php:master Nov 14, 2024
2 checks passed
@saundefined saundefined deleted the php84-curl-errors branch November 14, 2024 06:36
@jdkfx jdkfx mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@saundefined @Girgias