Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mistranslation in preg-match.xml #225

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix mistranslation in preg-match.xml #225

merged 1 commit into from
Dec 23, 2024

Conversation

nyan-dot
Copy link
Contributor

matchesは元から配列なので「配列に変更」は不適切で、後半も誤訳していたのでそれらを修正。
原文：

Note that this changes the value of matches into an array where every element is an array consisting of the matched string at offset 0 and its string offset into subject at offset 1.
https://www.php.net/manual/en/function.preg-match.php

KentarouTakeda
KentarouTakeda approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@KentarouTakeda KentarouTakeda merged commit e1f0f6e into php:master Dec 23, 2024
1 check passed
@nyan-dot nyan-dot deleted the patch-1 branch December 23, 2024 09:56
@nyan-dot nyan-dot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentarouTakeda KentarouTakeda KentarouTakeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyan-dot @KentarouTakeda