Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4: Document registerPhpFunctions() changes #261

Merged
merged 2 commits into from
Feb 11, 2025
Merged

PHP 8.4: Document registerPhpFunctions() changes #261

merged 2 commits into from
Feb 11, 2025

Conversation

Ippey
Copy link
Contributor

@Ippey Ippey commented Feb 10, 2025

php/doc-en#4114 を反映しました。

KentarouTakeda
KentarouTakeda approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！訳は大丈夫です！！

xmlの書き方の部分だけ修正させて頂きました。

<type>TYPENAME</type>

TYPENAME が正式な型名だった場合、対応する型の説明へリンクされます。その対応を行いました。
（結果的に文章として不自然になってしまった感があるのですが、他のページでも同じようになっている箇所がありこちらに統一してます）

@KentarouTakeda KentarouTakeda merged commit 601be21 into php:master Feb 11, 2025
2 checks passed
@KentarouTakeda KentarouTakeda mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentarouTakeda KentarouTakeda KentarouTakeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ippey @KentarouTakeda