Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled pcre2 to 10.43 #13413

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Feb 16, 2024

Note: the benchmarking diff is wrong because this branch is old (i.e. made in december during the 10.43RC1) and doesn't contain the flf performance improvement that are atm in master.
Once merged you will see a small drop in instruction count.

@Ayesh
Copy link
Member

Ayesh commented Feb 17, 2024

This is great, I was waiting for the 10.43 release too.

Should we document the changes in pattern matching in the UPGRADING file? I mean changes like in PCRE >= 10.43, /a{,3}/ is a valid quantity match while older versions matches the string literal.

@nielsdos
Copy link
Member Author

Should we document the changes in pattern matching in the UPGRADING file? I mean changes like in PCRE >= 10.43, /a{,3}/ is a valid quantity match while older versions matches the string literal.

Absolutely, I will do that.

@nielsdos nielsdos merged commit ae5beff into php:master Feb 17, 2024
7 of 10 checks passed
Ayesh added a commit to Ayesh/php-src that referenced this pull request Jun 7, 2024
Previously: phpGH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).
Ayesh added a commit to Ayesh/php-src that referenced this pull request Jun 7, 2024
Previously: phpGH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).

Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
Ayesh added a commit to Ayesh/php-src that referenced this pull request Jun 8, 2024
Previously: phpGH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).

Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
Ayesh added a commit to Ayesh/php-src that referenced this pull request Jun 8, 2024
Previously: phpGH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).

Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
Ayesh added a commit to Ayesh/php-src that referenced this pull request Jun 8, 2024
Previously: phpGH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).

Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
nielsdos pushed a commit that referenced this pull request Jun 8, 2024
Previously: GH-13413.

This version also contains a fix with `preg_match('\X')`, so that it
can correctly detect grapheme clusters (PCRE2Project/pcre2#410).
This is useful to correctly [polyfill the new `grapheme_str_split`
function](https://php.watch/versions/8.4/grapheme_str_split#polyfill).

Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants