8.4 UPGRADING document fixes #16201
Closed
8.4 UPGRADING document fixes #16201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
8.4-upgrading2
branch
from
4261f2f to
7da03f1
Compare
Girgias
added a commit
to Girgias/doc-en
that referenced
this pull request
Oct 3, 2024
cmb69
approved these changes
Oct 3, 2024
| @@ -742,7 +709,7 @@ PHP 8.4 UPGRADE NOTES | |||
| Along with these, five constants (Pdo\Firebird::TRANSACTION_ISOLATION_LEVEL, | |||
| Pdo\Firebird::READ_COMMITTED, Pdo\Firebird::REPEATABLE_READ, | |||
| Pdo\Firebird::SERIALIZABLE, Pdo\Firebird::WRITABLE_TRANSACTION) have been added. | |||
| . When using persistent connections, there is now a liveness check in the | |||
| . When using persistent connections, there is now a liveliness check in the | |||
There was a problem hiding this comment.
It seems to me that either is okay (https://www.merriam-webster.com/dictionary/liveness#:~:text=live%C2%B7%E2%80%8Bness,reverberant%20quality%20of%20a%20room).
There was a problem hiding this comment.
Well my IDE was complaining, I'll change it back.
There was a problem hiding this comment.
Not necessarily necessary. :) (My browser complains about almost every word I write; might enable English spellchecking at some point ;)
|
And please don't forget to merge into master when committing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found more issues while working on php/doc-en#3822