Reset Z_EXTRA_P(op2) of ZEND_INIT_FCALL for opcache file cache #20328
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset becomes stale if the environment changes. We're currently relying on other factors in the environment staying constant, e.g. send types. But this seems to be the worst offender. Partially addresses phpGH-17733
|
Okay for a workaround on first sight, but this should target 8.4, no? In any case, I would like this only as a temporary workaround and use a proper fix (using system id someway) to prevent the issue in a cleaner way (and more generally). |
Indeed. Based on 8.4 but forgot to change the branch when creating the PR.
Yes, that's fine. I'll make sure to extend the comment so we know to revert it. |
This would benefit SHM reattachment too, which likely suffers from similar issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset becomes stale if the environment changes. We're currently relying on other factors in the environment staying constant, e.g. send types. But this seems to be the worst offender.
Partially addresses GH-17733