Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for phpstan/phpdoc-parser 2 #212

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Nov 7, 2024

No description provided.

@xabbuh xabbuh force-pushed the phpstan-phpdoc-parser-2 branch 2 times, most recently from 25aa933 to 6e28db3 Compare November 7, 2024 14:06
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help to upgrade, I think we should accept the issues in the pipeline by adding the phpstan errors to the baseline. And add the missing symbol to the composer-require-checker config.

Let me know if you need any help with that.

@xabbuh xabbuh force-pushed the phpstan-phpdoc-parser-2 branch 3 times, most recently from 9ee57f8 to 28b0f48 Compare November 8, 2024 08:37
@xabbuh
Copy link
Contributor Author

xabbuh commented Nov 8, 2024

@jaapio thanks for the feedback, I guess this should be good now

@jaapio jaapio merged commit 679e3ce into phpDocumentor:1.x Nov 9, 2024
29 checks passed
@jaapio
Copy link
Member

jaapio commented Nov 9, 2024

Merged and a new tag has been created. Thanks for your help

@xabbuh xabbuh deleted the phpstan-phpdoc-parser-2 branch November 9, 2024 16:38
@xabbuh
Copy link
Contributor Author

xabbuh commented Nov 9, 2024

Thank you for the fast release! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants