fix: Add consideration of Node\Attribute to FileVisitor #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlessandroMinoccheri can you take a look at this PR? |
|
Hey @philipp-yoummday, thank you for your contribution! Would it be possibile to add a test for the new behaviour? |
|
@micheleorselli thank you for your comment! Please let me know if that test is sufficient enough for you. |
|
@philipp-yoummday would you mind rebasing to master? build should be working now, thanks! 🙇 |
philipp-yoummday
force-pushed
the
bugfix/fileVisitor/add-attributes
branch
from
8d107b5 to
2f02e40
Compare
|
@micheleorselli good morning, thanks a lot! Rebase is done. |
micheleorselli
force-pushed
the
bugfix/fileVisitor/add-attributes
branch
from
2f02e40 to
106cc5a
Compare
|
one last tests fails, would you mind fixing it? |
philipp-yoummday
force-pushed
the
bugfix/fileVisitor/add-attributes
branch
from
ba4b656 to
8aa5c47
Compare
|
@micheleorselli please let the pipeline run again. It should be working now. |
|
Thank you @philipp-yoummday ! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment imports of Attributes are ignored. This results in unreliable code analysis.
I've adjusted the code to take imports from attributes into account.