From 7383e35a2541edb66ccd9b1ae5f9db9c234c0adc Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:07:15 +0200 Subject: [PATCH 1/6] Require a . after the event naming. --- src/Tests/Tests/epv_test_validate_event_names.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 0176d0f..61f4ad5 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -43,7 +43,8 @@ public function validateDirectory(array $dirList) } $events = $exporter->get_events(); - $vendor = strtolower(str_replace('/', '.', $this->namespace)); // event names are requierd to be lowercase! + $this->output->inMaxPogress(sizeof($events) * 3); + $vendor = strtolower(str_replace('/', '.', $this->namespace)) + '.'; // event names are requierd to be lowercase! foreach ($events as $event) { From 583d7e4bbb7198640bfb47264541c5d595fe43d7 Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:17:10 +0200 Subject: [PATCH 2/6] Fixed rebase --- src/Tests/Tests/epv_test_validate_event_names.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 61f4ad5..257a836 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -43,7 +43,6 @@ public function validateDirectory(array $dirList) } $events = $exporter->get_events(); - $this->output->inMaxPogress(sizeof($events) * 3); $vendor = strtolower(str_replace('/', '.', $this->namespace)) + '.'; // event names are requierd to be lowercase! foreach ($events as $event) From 70af9aaf30949d45460733c18dffd56b572c111c Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:25:25 +0200 Subject: [PATCH 3/6] Update epv_test_validate_event_names.php --- src/Tests/Tests/epv_test_validate_event_names.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 257a836..9bfe1ac 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -43,7 +43,9 @@ public function validateDirectory(array $dirList) } $events = $exporter->get_events(); - $vendor = strtolower(str_replace('/', '.', $this->namespace)) + '.'; // event names are requierd to be lowercase! + // event names are requierd to be lowercase + // event names should end with a dot to seperate the vendor.name and the actual event name. + $vendor = strtolower(str_replace('/', '.', $this->namespace)) + '.'; foreach ($events as $event) { @@ -67,6 +69,6 @@ public function validateDirectory(array $dirList) public function testName() { - return "Validate directory structure"; + return "test even names"; } } From 6d4d71ce54552268fb548c96bbaf075fb080bf71 Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:25:47 +0200 Subject: [PATCH 4/6] Typo fixed --- src/Tests/Tests/epv_test_validate_event_names.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 9bfe1ac..225dbb0 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -43,7 +43,7 @@ public function validateDirectory(array $dirList) } $events = $exporter->get_events(); - // event names are requierd to be lowercase + // event names are required to be lowercase // event names should end with a dot to seperate the vendor.name and the actual event name. $vendor = strtolower(str_replace('/', '.', $this->namespace)) + '.'; From fb842675533dbeb63a9ac2bcac384e92f26fca62 Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:27:45 +0200 Subject: [PATCH 5/6] Fix test name --- src/Tests/Tests/epv_test_validate_event_names.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 225dbb0..4d22d5e 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -69,6 +69,6 @@ public function validateDirectory(array $dirList) public function testName() { - return "test even names"; + return "test event names"; } } From 480555bbb13395be7b41ffc595e251e1cc60c432 Mon Sep 17 00:00:00 2001 From: Paul Sohier Date: Mon, 25 Jul 2016 11:30:09 +0200 Subject: [PATCH 6/6] Use a uppercase letter for the testName --- src/Tests/Tests/epv_test_validate_event_names.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tests/Tests/epv_test_validate_event_names.php b/src/Tests/Tests/epv_test_validate_event_names.php index 4d22d5e..869313e 100644 --- a/src/Tests/Tests/epv_test_validate_event_names.php +++ b/src/Tests/Tests/epv_test_validate_event_names.php @@ -69,6 +69,6 @@ public function validateDirectory(array $dirList) public function testName() { - return "test event names"; + return "Test event names"; } }